-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for special tunable values outside of the range #617
Conversation
…values; implement TunableGroups to ConfigSpace conversion. TODO: convert from ConfigSpace back to Tunablegroups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits here and there, but I think the main thing we should revisit is whether to support mixed numerical and string types for special values.
Co-authored-by: Brian Kroth <[email protected]>
Co-authored-by: Brian Kroth <[email protected]>
Co-authored-by: Brian Kroth <[email protected]>
…sergiym/tunable/special
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I left one place to add a comment that probably needs some pylint checks for spacing.
I think one tweak we/I could add in a future PR would be to update the json schemas to account for disallowing ! characters in the names, but that doesn't have to be here.
Enables special values outside of the range (e.g.,
-1
with a range of[0, 100]
).To do we make use of "conditionals" in ConfigSpace to constrain the space. This has a number of implementation implications, addressed below:
Tunable
classTunable
objectsConfigSpace
conversionTunableGroups
toConfigSpace
conversion for tunables with special valuesmlos_core
optimizers to support conditionals and special values inConfigSpace
ConfigSpace