Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for MlosCoreoptimizer._to_df() functionality; use special values in tunables #638

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Add unit tests for MlosCoreoptimizer._to_df() functionality; use special values in tunables #638

merged 5 commits into from
Jan 18, 2024

Conversation

motus
Copy link
Member

@motus motus commented Jan 18, 2024 •
edited
Loading

  • Use special values outside of the regular range for some tunables in the unit tests
  • Add unit tests to validate the data conversion between tunables and ConfigSpace-based inputs to mlos_core optimizers

Closes #636

@motus motus requested a review from a team as a code owner January 18, 2024 01:01
@motus motus added ready for review Ready for review tests Add or fix unit tests mlos-bench labels Jan 18, 2024
@motus motus force-pushed the sergiym/opt/test_conf2df branch from 93ed059 to 3db144d Compare January 18, 2024 02:14
bpkroth
bpkroth approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@bpkroth bpkroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@motus motus enabled auto-merge (squash) January 18, 2024 23:05
@motus motus merged commit 713510f into microsoft:main Jan 18, 2024
11 checks passed
@motus motus deleted the sergiym/opt/test_conf2df branch January 18, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpkroth bpkroth bpkroth approved these changes

Assignees
No one assigned
Labels
mlos-bench ready for review Ready for review tests Add or fix unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests for MlosCoreOptimizer._to_df() functionality
2 participants
@motus @bpkroth