Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups for recent changes in sphinx dependencies #954

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Fixups for recent changes in sphinx dependencies #954

merged 1 commit into from
Feb 22, 2025
+16 −11

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Feb 21, 2025

Pull Request

Title

Fixups for recent changes in sphinx dependencies

Description

  • Changes the type resolution for a few type aliases from data to type
  • Excludes flaml's Domain type from resolution.
  • Excludes Future from resolution nitpick (similar error to Ellipsis)
  • Documents the new versions that caused these.

Type of Change

  • 🛠️ Bug fix
  • 📝 Documentation update

@bpkroth bpkroth requested a review from a team as a code owner February 21, 2025 18:59
@bpkroth bpkroth added ready for review Ready for review bug Something isn't working documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file ci labels Feb 21, 2025
@bpkroth bpkroth mentioned this pull request Feb 21, 2025
Merged
@motus motus merged commit df347c9 into microsoft:main Feb 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motus motus motus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ci dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpkroth @motus