Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Supply dynamic_shapes in ONNX export when dynamo=True #1478

Open
1 of 7 tasks
justinchuby opened this issue Nov 11, 2024 · 0 comments
Open
1 of 7 tasks

[FR]: Supply dynamic_shapes in ONNX export when dynamo=True #1478

justinchuby opened this issue Nov 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@justinchuby
Copy link
Contributor

Proposal Summary

Supply dynamic_shapes in ONNX export when dynamo=True

What component(s) does this request affect?

  • OliveModels
  • OliveSystems
  • OliveEvaluator
  • Metrics
  • Engine
  • Passes
  • Other
@justinchuby justinchuby added the enhancement New feature or request label Nov 11, 2024
shaahji pushed a commit that referenced this issue Nov 12, 2024
## Describe your changes

For the Olive release, in the ONNX export pass, since when `dynamo=True`
the dynamic_shapes argument is not provided properly, we temporarily
change the check to require torch 2.6 to enable the new `dynamo=True`
logic pass. This way when a user has torch 2.5 Olive will still use the
old `dynamo_export` logic and function without errors.

## Checklist before requesting a review
- [ ] Add unit tests for this change.
- [ ] Make sure all tests can pass.
- [ ] Update documents if necessary.
- [ ] Lint and apply fixes to your code by running `lintrunner -a`
- [ ] Is this a user-facing change? If yes, give a description of this
change to be included in the release notes.
- [ ] Is this PR including examples changes? If yes, please remember to
update [example
documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md)
in a follow-up PR.

## (Optional) Issue link

- #1478
@justinchuby justinchuby added bug Something isn't working and removed bug Something isn't working labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant