Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set to use dynamo=True only with PyTorch 2.6 temporarily #1479

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

justinchuby
Copy link
Contributor

@justinchuby justinchuby commented Nov 11, 2024

Describe your changes

For the Olive release, in the ONNX export pass, since when dynamo=True the dynamic_shapes argument is not provided properly, we temporarily change the check to require torch 2.6 to enable the new dynamo=True logic pass. This way when a user has torch 2.5 Olive will still use the old dynamo_export logic and function without errors.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

For the Olive release, in the ONNX export pass, since when `dynamo=True` the dynamic_shapes argument is not provided properly, we temporarily change the check to require torch 2.6 to enable the new `dynamo=True` logic pass. This way when a user has torch 2.5 Olive will still use the old `dynamo_export` logic and function without errors.
@justinchuby justinchuby changed the title Set to use dynamo=True only in PyTorch 2.6 temporarily Set to use dynamo=True only with PyTorch 2.6 temporarily Nov 11, 2024
@jambayk jambayk requested a review from shaahji November 12, 2024 03:13
Copy link
Contributor

@shaahji shaahji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model exports succeeding.

@shaahji shaahji merged commit ddf98d0 into main Nov 12, 2024
25 checks passed
@shaahji shaahji deleted the justinchu/dynamic-shapes-todo branch November 12, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants