Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for removing shapes from WF specifications #146

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

EliasC
Copy link
Contributor

@EliasC EliasC commented Sep 26, 2024

This PR adds support for removing shapes from a WF specification:

inline const auto wf1 =
  (Foo <<= Bar++)
| Baz <<= Foo * Bar
;

inline const auto wf2 =
  (wf1 - Foo)
  | Bar <<= Baz++

In wf2 Foos can still appear in the tree, but they must have zero children (just like if they were never in the WF to begin with). Without this PR, the only way to achieve the same functionality is by repeating the shape list without Foo.

To be honest, I'm not sure what I'm doing with the functions taking rvalues, I'm just parroting other similar functions.

@mjp41
Copy link
Member

mjp41 commented Sep 26, 2024

LGTM

@sylvanc sylvanc merged commit 58d4807 into microsoft:main Sep 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants