Fuzzer started from second instead of first pass as default when using Driver #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
run()
method indriver.h
, the "test_start_pass"
for fuzzing was previously selected astest_start_pass = pass_names.at(1);
which gives the second pass after the parser but compensates for the initial pass being the pass atstart_index - 1
in the methodtest()
in theFuzzer
class.However, the start_index for the returned
Fuzzer
object returned fromreader.pass_index()
compensates in the other direction and adds +1 to the pass index, meaning the first pass in the pass sequence in the reader does not get tested if not given explicitly.I just added the minimal fix to start fuzz testing from the first pass as default, but perhaps the logic in
pass_index
andtest()
could also be changed.