Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup & folder structure improvements #1732

Merged
merged 29 commits into from
Feb 5, 2025
Merged

Cleanup & folder structure improvements #1732

merged 29 commits into from
Feb 5, 2025

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Jan 28, 2025 •
edited
Loading

This PR removes unused files, and restructures the entire project:

  • Control pages and sample-related code now lives in the Samples folder.
  • Gallery related helpers, pages and other things live in their respective folders.
  • A lot of XAML styler formatting (we need to create a script for this).
  • Picking up the changes from: Remove ElementAnimator and related WINUI_PRERELEASE code #1733
  • Removing a bunch of dead-code / unused namings

image

@niels9001 niels9001 marked this pull request as ready for review January 29, 2025 09:27
@niels9001 niels9001 changed the title Cleanup Cleanup & folder structure improvements Jan 29, 2025
@marcelwgn
Copy link
Contributor

/azp run

@niels9001
Copy link
Contributor Author

/azp run

@Jay-o-Way Jay-o-Way mentioned this pull request Jan 29, 2025
Open
@niels9001
Copy link
Contributor Author

/azp run

@karkarl
Copy link
Collaborator

karkarl commented Jan 30, 2025

Looks great!

I wonder if "Controls" directory containing WinUI-Gallery defined userControls should be renamed to "UserControls" or something else instead? It always confuses me since this is a controls app gallery. This can be a separate PR.

@Zakariathr22
Copy link
Contributor

Well done! Does this PR Close #1614?

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Jan 30, 2025 •
edited
Loading

Looks great!

I wonder if "Controls" directory containing WinUI-Gallery defined userControls should be renamed to "UserControls" or something else instead? It always confuses me since this is a controls app gallery. This can be a separate PR.

Totally agree! I've been thinking about that for a while too. "XamlControls" for the other folder/namespace makes sense too... Let's discuss this in #1673

@niels9001
Copy link
Contributor Author

Looks great!
I wonder if "Controls" directory containing WinUI-Gallery defined userControls should be renamed to "UserControls" or something else instead? It always confuses me since this is a controls app gallery. This can be a separate PR.

Totally agree! I've been thinking about that for a while too. "XamlControls" for the other folder/namespace makes sense too... Let's discuss this in #1673

We've moved most sample-related content in the Samples folder, so if you don't need to touch the Gallery-shell that'd be the place to be. Everything else is related to the app itself. I want to avoid having differences in folder names and namespaces, and updating those now is a pain due to the many conflicts and changes required - if we want to do this is in the future, better to do it in a separate PR.

@niels9001
Copy link
Contributor Author

/azp run

@niels9001
Copy link
Contributor Author

/azp run

@niels9001 niels9001 merged commit 2fbc60a into main Feb 5, 2025
2 checks passed
@niels9001 niels9001 deleted the user/niels9001/cleanup branch February 5, 2025 12:38
@niels9001 niels9001 mentioned this pull request Feb 5, 2025
Draft
3 tasks
@marcelwgn marcelwgn mentioned this pull request Feb 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karkarl karkarl karkarl left review comments

@Jay-o-Way Jay-o-Way Jay-o-Way left review comments

@marcelwgn marcelwgn marcelwgn approved these changes

@zinniaa zinniaa Awaiting requested review from zinniaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@niels9001 @marcelwgn @karkarl @Zakariathr22 @Jay-o-Way