Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off @azure/ms-rest-js #2560

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

MikhailSuendukov
Copy link
Contributor

@MikhailSuendukov MikhailSuendukov commented Dec 21, 2024

Description

The package @azure/ms-rest-js is no longer being actively maintained. So, moving to @azure/core-rest-pipeline and @azure/core-client packages.

Build succeed.

Links

#2549
AB#109355

@DordeDimitrijev
Copy link
Contributor

Can you please attach build inside description?

Copy link
Contributor

@IlyaBausovAkvelon IlyaBausovAkvelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only ClientRequest Interface is needed from create-client.ts. I've made branch fix/remove-ms-rest-js-related-unused-code with these changes.

src/util/apis/appcenter-client-credentials.ts Outdated Show resolved Hide resolved
src/util/apis/create-client.ts Outdated Show resolved Hide resolved
src/util/apis/create-client.ts Outdated Show resolved Hide resolved
@DordeDimitrijev
Copy link
Contributor

DordeDimitrijev commented Jan 16, 2025

I've also checked it out and I suppose we can merge the changes from fix/remove-ms-rest-js-related-unused-code into this PR and update the description?

src/commands/codepush/lib/react-native-utils.ts Outdated Show resolved Hide resolved
@MikhailSuendukov MikhailSuendukov dismissed IlyaBausovAkvelon’s stale review January 20, 2025 11:49

The merge-base changed after approval.

@MikhailSuendukov MikhailSuendukov dismissed DmitriyKirakosyan’s stale review January 20, 2025 15:55

The merge-base changed after approval.

@MikhailSuendukov MikhailSuendukov dismissed IlyaBausovAkvelon’s stale review January 21, 2025 09:39

The merge-base changed after approval.

@MikhailSuendukov MikhailSuendukov dismissed DordeDimitrijev’s stale review January 21, 2025 10:44

The merge-base changed after approval.

@MikhailSuendukov MikhailSuendukov dismissed DmitriyKirakosyan’s stale review January 22, 2025 09:22

The merge-base changed after approval.

@DmitriyKirakosyan DmitriyKirakosyan self-requested a review January 22, 2025 09:23
@MikhailSuendukov MikhailSuendukov dismissed DmitriyKirakosyan’s stale review January 22, 2025 09:31

The merge-base changed after approval.

@MikhailSuendukov MikhailSuendukov dismissed IlyaBausovAkvelon’s stale review January 22, 2025 09:42

The merge-base changed after approval.

lucen-ms
lucen-ms previously approved these changes Jan 22, 2025
@MikhailSuendukov MikhailSuendukov dismissed lucen-ms’s stale review January 22, 2025 13:22

The merge-base changed after approval.

@MikhailSuendukov MikhailSuendukov merged commit b0978e2 into master Jan 22, 2025
1 check passed
@MikhailSuendukov MikhailSuendukov deleted the migrate-off-ms-rest-js branch January 22, 2025 14:18
@DordeDimitrijev DordeDimitrijev mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants