Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET] Add happy path test for in-memory agent && Simplify HelloAgent example && some clean-up in extension APIs #4227

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

LittleLittleCloud
Copy link
Collaborator

@LittleLittleCloud LittleLittleCloud commented Nov 15, 2024

Why are these changes needed?

This PR does the following work

  • Add happy-path test for in-memory use case
  • Improve the existing extension APIs (essentially replacing WebApplicationBuilder -> IHostApplicationBuilder)
  • disable GRPC sample in HelloAgent sample

Related issue number

Checks

@LittleLittleCloud LittleLittleCloud changed the title [.NET] Add happy path test for in-memory agent && some clean-up in extension APIs [.NET] Add happy path test for in-memory agent && Simplify HelloAgent example && some clean-up in extension APIs Nov 15, 2024
Copy link
Collaborator

@rysweet rysweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. did you try this with grpc as well to make sure it still works? it conflicts with some changes Reuben was proposing that used the .Web SDK instead of .SDK. the changes to HelloAgents I am less thrilled about mainly because I liked how the previous version did everything in one shot. maybe we could have both?

I haven't had time to try and run this yet and make sure it still also works with gprc. If you have done that let me know and I'll go ahead and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants