Postgres Parameters Page #13855

nasc17 · 2020-12-18T19:05:02Z

Getting postgres parameters page. Users can perform actions such as connection to PostgresSQL server, viewing engine settings with their current values, searching through rows, setting server parameters, and resetting parameters to default values,

UI is currently freezing when trying to populate large amount of server parameters in the declarative table. Bug issued here: #13905

…ss connection

…me, and function to create error message

…Postgres. (#13532) * connectSqlDialog is an abstract class. Separated out Miaa and Postgress connection * Simplified classes extending ConnectToSqlDialog, added get providerName, and function to create error message * Miaa models provides dialog title * Updated failed message parameters * completionPromise.reject * Fixed connect to MSSql * removed this._completionPromise.reject

Charles-Gagnon · 2021-01-21T18:27:44Z

extensions/arc/src/localizedConstants.ts

@@ -173,6 +175,8 @@ export function rangeSetting(min: string, max: string): string { return localize
 export function allowedValue(value: string): string { return localize('arc.allowedValue', "Value is expected to be {0}", value); }
 export function databaseCreated(name: string): string { return localize('arc.databaseCreated', "Database {0} created", name); }
 export function deletingInstance(name: string): string { return localize('arc.deletingInstance', "Deleting instance '{0}'...", name); }
+export function installingExtension(name: string): string { return localize('arc.installingExtension', "Installing extension '{0}'...", name); }
+export function extensionInstalled(name: string): string { return localize('arc.extensionInstalled', "Extension'{0}' has been installed.", name); }


space after Extension

Charles-Gagnon · 2021-01-21T19:09:53Z

extensions/arc/src/ui/dashboards/postgres/postgresParametersPage.ts

-		return [];
+	private createParameters(): void {
+		this._parameters = [];
+		this._postgresModel._engineSettings.forEach(engineSetting => {


this._parameters = this._postgresModel._engineSettings.map(engineSetting => this.createParameterComponents(engineSetting));

Charles-Gagnon · 2021-01-21T19:13:36Z

extensions/arc/src/ui/dashboards/postgres/postgresParametersPage.ts

-	private handleEngineSettingsUpdated(): void {
-		//TODO
+	private async callGetEngineSettings(): Promise<void> {
+		await this._postgresModel.getEngineSettings().catch(err => {


Use try/catch instead of catch callbacks

Charles-Gagnon · 2021-01-21T19:16:46Z

extensions/arc/src/ui/dashboards/postgres/postgresParametersPage.ts

-		//TODO
+	private async callGetEngineSettings(): Promise<void> {
+		await this._postgresModel.getEngineSettings().catch(err => {
+			// If an error occurs show a message so the user knows something failed but still


This comment doesn't seem to match what's going on here

…ge (#14003)

* change config steps to sync * fix tests * use pathexistsSync * remove pathExistsSync call * address PR comments

…ecoming invisible. (#14008)

* Fix validation errors * fix compile * update return type

* Clean up button component disposables * consolidate logic

…tes(#13859) * Dacpac telmetry code changes * Removed added spaces * Generate deployScript accessibility changed back to public * code review suggessions updates * dacpac extension tests fixes * Updated time and filesize methods allowing general return values * Telemetry code updates * Dacpac Telemetry potential data loss capture and PII error excluded * Dacpac telemetry code updates for comments * Wizard pages navigation telemetry event capture moved to the core * DacpacTelemetry code updates * Extension wizard cancel telemetry for data loss * Dacpac telemetry pagename and small code updates * final Dacpac telemetry code updates...

resources/localization/LCL/fr/cms.xlf.lcl

extensions/arc/src/ui/dashboards/postgres/postgresParametersPage.ts

bergeron · 2021-01-26T21:21:58Z

extensions/arc/src/ui/dashboards/postgres/postgresParametersPage.ts

-								this.engineSettingUpdates!.forEach((value: string) => {
-									this.engineSettings += value + ', ';
+								this.parameterUpdates!.forEach((value, key) => {
+									engineSettings.push(`${key}=${value}`);


I thought --engine-settings accepted a comma separated list. Are the settings comma separated somewhere?

The array uses the toString method when passing into the command to show as comma separated.

extensions/arc/src/ui/dashboards/postgres/postgresParametersPage.ts

* Addition: properties page with link to dashboard * Include new page * Initial Parameter page start * Include new changes from merged PRs * Including new constants * Git errors * Add parameter commands and help * Reset command * Added chart * git fix * Fixed string issues * connectSqlDialog is an abstract class. Separated out Miaa and Postgress connection * Initial start to adding connect to sql for postgres instance * Simplified classes extending ConnectToSqlDialog, added get providerName, and function to create error message * Miaa models provides dialog title * Updated failed message parameters * completionPromise.reject * Fixed connect to MSSql * Messy dialog showing from button * removed this._completionPromise.reject * Cleaning up code * Set connectSqlDialog to be an abstract class. Separated out Miaa and Postgres. (#13532) * connectSqlDialog is an abstract class. Separated out Miaa and Postgress connection * Simplified classes extending ConnectToSqlDialog, added get providerName, and function to create error message * Miaa models provides dialog title * Updated failed message parameters * completionPromise.reject * Fixed connect to MSSql * removed this._completionPromise.reject * Connect button clean up * Format * Format doc * Fixed compile errors * Cleaning up page * Clean up * clean up refresh * Format doc * Removed ellipse * Cleaning up problems * Updating localized constants * Missing username update * Get connection profile added to Resource model, abstract method created for calling connection dialog * Added createConnectionProfile * took out import * Pulled in new changes, fixed usercancellederror * Getting engine settings * Git errors * Git errors * Git errors fix * Fixing Css * Freezes, Search function working, 20 parameters * Fixed re * Git errors * Save and reset commands working * Discard works, updated how engine settings refresh with model * Updated search, add back loading for when trying to connect * Cleaning up comments left in code * Git error * Corrected names of icons and constants, Fixed Miaa dialog title * Removed using any on page, added void return types, took out commented code * Changed gear svg, made postgres extension a loc constant, fixed formatting * Fixed controller model name * Put connection profile and id in resource model, changed back controller model in base class * Fixed a comment * Added loading component for waiting for postgres extension to be installed * Fix parameters page to show parameters if engine settings are already loaded (#13996) * Added progress message for installing postgres extension * Minor styling updates * Making sure search box and rest buttons are enabled when opening page with loaded data. Update refresh * Git errors * change name * Code review updates: Combined create parameters and refresh table. * Update sql-assessment to use latest ads-extension-telemetry npm package (#14003) * Change configure Jupyter server steps from async to sync (#13937) * change config steps to sync * fix tests * use pathexistsSync * remove pathExistsSync call * address PR comments * Use a minimum cell height to prevent whitespace markdown cells from becoming invisible. (#14008) * Fix validation errors (#14009) * Fix validation errors * fix compile * update return type * Cleanup model component wrapper event handlers (#14012) * Clean up button component disposables (#14011) * Clean up button component disposables * consolidate logic * Adding Dacpac extension telemetry and core wizard/page telemetry updates(#13859) * Dacpac telmetry code changes * Removed added spaces * Generate deployScript accessibility changed back to public * code review suggessions updates * dacpac extension tests fixes * Updated time and filesize methods allowing general return values * Telemetry code updates * Dacpac Telemetry potential data loss capture and PII error excluded * Dacpac telemetry code updates for comments * Wizard pages navigation telemetry event capture moved to the core * DacpacTelemetry code updates * Extension wizard cancel telemetry for data loss * Dacpac telemetry pagename and small code updates * final Dacpac telemetry code updates... * migrated loc files (#14015) * Took out some info bubbles and addingitems * Update search function * Handle special value occasions * Undo change * Undo change Co-authored-by: chgagnon <[email protected]> Co-authored-by: Lucy Zhang <[email protected]> Co-authored-by: Cory Rivera <[email protected]> Co-authored-by: Sai Avishkar Sreerama <[email protected]> Co-authored-by: khoiph1 <[email protected]>

nasc17 and others added 30 commits November 2, 2020 14:14

Addition: properties page with link to dashboard

b8dcf1e

Include new page

de7ac2d

Initial Parameter page start

388a4a2

Include new changes from merged PRs

e3fe759

Including new constants

86d3072

Git errors

2ed0fed

Add parameter commands and help

d978925

Reset command

0b858b4

Added chart

6ebafb2

git fix

7cd2c25

Fixed string issues

35c80ab

connectSqlDialog is an abstract class. Separated out Miaa and Postgre…

454c409

…ss connection

Initial start to adding connect to sql for postgres instance

577faa7

Simplified classes extending ConnectToSqlDialog, added get providerNa…

e178ed4

…me, and function to create error message

Miaa models provides dialog title

cd321c0

Updated failed message parameters

a1fe20c

completionPromise.reject

ec39abb

Merge updates for dialog

0a757e4

Fixed connect to MSSql

9393f14

Messy dialog showing from button

701c1e1

removed this._completionPromise.reject

18752ac

Cleaning up code

2d49fd0

Merge conflicts

2068f8d

Connect button clean up

a4e6776

Format document

75ec0e9

Up to date with main, and pulled in new dialog connections

3fddfd2

Format

a1e3656

Format doc

f2e697f

Fixed compile errors

546a930

nasc17 and others added 2 commits January 20, 2021 14:20

Git errors

f1cf35a

change name

29ae3e1

Charles-Gagnon approved these changes Jan 21, 2021

View reviewed changes

nasc17 and others added 10 commits January 21, 2021 13:00

Code review updates: Combined create parameters and refresh table.

55c84a2

Update sql-assessment to use latest ads-extension-telemetry npm packa…

87d6271

…ge (#14003)

Change configure Jupyter server steps from async to sync (#13937)

ca9732d

* change config steps to sync * fix tests * use pathexistsSync * remove pathExistsSync call * address PR comments

Use a minimum cell height to prevent whitespace markdown cells from b…

444304c

…ecoming invisible. (#14008)

Fix validation errors (#14009)

dcffff6

* Fix validation errors * fix compile * update return type

Cleanup model component wrapper event handlers (#14012)

daac969

Clean up button component disposables (#14011)

9daea99

* Clean up button component disposables * consolidate logic

migrated loc files (#14015)

3177355

Merge branch 'main' into nasc/PostgresParametersPage

62ea4d8

bergeron reviewed Jan 26, 2021

View reviewed changes

resources/localization/LCL/fr/cms.xlf.lcl Outdated Show resolved Hide resolved

Took out some info bubbles and addingitems

f64f26f

nasc17 requested review from alanrenmsft, Benjin and kisantia as code owners January 26, 2021 21:10

bergeron reviewed Jan 26, 2021

View reviewed changes

extensions/arc/src/ui/dashboards/postgres/postgresParametersPage.ts Outdated Show resolved Hide resolved

bergeron reviewed Jan 26, 2021

View reviewed changes

extensions/arc/src/ui/dashboards/postgres/postgresParametersPage.ts Outdated Show resolved Hide resolved

nasc17 force-pushed the nasc/PostgresParametersPage branch from 19cfd3e to f64f26f Compare January 26, 2021 21:43

nasc17 added 4 commits January 26, 2021 14:07

Update search function

386dcb5

Handle special value occasions

761416a

Undo change

3ad9303

Undo change

88bacd3

bergeron approved these changes Jan 29, 2021

View reviewed changes

nasc17 merged commit d98ac86 into main Jan 29, 2021

nasc17 deleted the nasc/PostgresParametersPage branch January 29, 2021 21:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Postgres Parameters Page #13855

Postgres Parameters Page #13855

nasc17 commented Dec 18, 2020 •

edited

Loading

Charles-Gagnon Jan 21, 2021

Charles-Gagnon Jan 21, 2021

Charles-Gagnon Jan 21, 2021

Charles-Gagnon Jan 21, 2021

bergeron Jan 26, 2021

nasc17 Jan 26, 2021

Postgres Parameters Page #13855

Postgres Parameters Page #13855

Conversation

nasc17 commented Dec 18, 2020 • edited Loading

Charles-Gagnon Jan 21, 2021

Choose a reason for hiding this comment

Charles-Gagnon Jan 21, 2021

Choose a reason for hiding this comment

Charles-Gagnon Jan 21, 2021

Choose a reason for hiding this comment

Charles-Gagnon Jan 21, 2021

Choose a reason for hiding this comment

bergeron Jan 26, 2021

Choose a reason for hiding this comment

nasc17 Jan 26, 2021

Choose a reason for hiding this comment

nasc17 commented Dec 18, 2020 •

edited

Loading