Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for [UX] Migrate existing markdown content to TSX pages #1056 Turn UX Design to Implementation #1077

Merged
merged 25 commits into from
Nov 28, 2024

Conversation

jamelachahbar
Copy link
Contributor

@jamelachahbar jamelachahbar commented Oct 27, 2024

πŸ› οΈ Description

#1056
PR for turning figma design into implementation.
Top Menu Bar, Sidebar + Sample Page created.
Tests created

πŸ“· Screenshots

image

Jest test results

image

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • [] 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@jamelachahbar
Copy link
Contributor Author

@flanakin, I forget to sync with latest from ux branch. There are conflicts that need to be resolved.
Should we always create new branch with each change? This one contains the commits of the previews pr, only the last commit should be reviewed.

@jamelachahbar
Copy link
Contributor Author

jamelachahbar commented Oct 27, 2024 via email

@akiskips akiskips self-requested a review October 28, 2024 12:04
Copy link
Contributor

@akiskips akiskips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested deployment locally

@flanakin flanakin requested a review from Ivanmtta October 29, 2024 08:19
src/web/components/SideBar.tsx Outdated Show resolved Hide resolved
src/web/components/TopMenuBar.tsx Outdated Show resolved Hide resolved
src/web/package.json Outdated Show resolved Hide resolved
src/web/pages/PowerBIReportsPage.tsx Outdated Show resolved Hide resolved
src/web/pages/SamplePage.tsx Outdated Show resolved Hide resolved
src/web/public/logo-windows.png Outdated Show resolved Hide resolved
src/web/public/sidebar-left-svgrepo-com.png Outdated Show resolved Hide resolved
src/web/public/sidebar-right-svgrepo-com.png Outdated Show resolved Hide resolved
src/web/tsconfig.json Outdated Show resolved Hide resolved
src/web/tsconfig.json Outdated Show resolved Hide resolved
@flanakin
Copy link
Collaborator

Looking at Ivan's feedback, I'm thinking we should probably break this PR down into smaller chunks to make progress. We can break theming, CSS breakout, localization, code cleanup, etc into separate tasks.

@flanakin flanakin added Needs: Attention πŸ‘‹ Issue or PR needs to be reviewed by the author or it will be closed due to no activity Tool: Web app Web app to learn about and manage toolkit resources. and removed Needs: Review πŸ‘€ PR that is ready to be reviewed labels Nov 17, 2024
@arthurclares arthurclares merged commit 1b30960 into features/ux Nov 28, 2024
1 check passed
@arthurclares arthurclares deleted the jachahbar/ux branch November 28, 2024 14:50
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Review πŸ‘€ PR that is ready to be reviewed and removed Needs: Attention πŸ‘‹ Issue or PR needs to be reviewed by the author or it will be closed due to no activity labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: Web app Web app to learn about and manage toolkit resources.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants