PR for [UX] Migrate existing markdown content to TSX pages #1056 Turn UX Design to Implementation

[jamelachahbar]

🛠️ Description

#1056
PR for turning figma design into implementation.
Top Menu Bar, Sidebar + Sample Page created.
Tests created

📷 Screenshots

Jest test results

📋 Checklist

🔬 How did you test this change?

• 🤏 Lint tests
• [] 🤞 PS -WhatIf / az validate
• 👍 Manually deployed + verified
• 💪 Unit tests
• 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

• 🚨 This is a breaking change.
• 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

• ✅ Updated changelog (required for dev PRs)
• ➡️ Will add log in a future PR (feature branch PRs only)
• ❎ Log not needed (small/internal change)

📖 Did you update documentation?

• ✅ Public docs in docs (required for dev)
• ✅ Internal dev docs in src (required for dev)
• ➡️ Will add docs in a future PR (feature branch PRs only)
• ❎ Docs not needed (small/internal change)

[jamelachahbar]

@flanakin, I forget to sync with latest from ux branch. There are conflicts that need to be resolved.
Should we always create new branch with each change? This one contains the commits of the previews pr, only the last commit should be reviewed.

[jamelachahbar]

Thanks, I forgot it. I'll commit it

…

On Sun, 27 Oct 2024 at 23:25, Orthodoxos Kipouridis < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/web/pages/App.tsx <#1077 (comment)> : > @@ -1,27 +1,41 @@ -import './App.css'; +import { BrowserRouter as Router, Route, Routes } from 'react-router-dom'; +import HomePage from './HomePage'; +import FinOpsHubsPage from './FinOpsHubsPage'; +import FinOpsWorkbooksPage from './FinOpsWorkbooksPage'; +import GovernanceWorkbookPage from './GovernanceWorkbookPage'; +import AzureOptimizationEnginePage from './AzureOptimizationEnginePage'; +import PowerShellModulePage from './PowerShellModulePage'; +import BicepRegistryModulesPage from './BicepRegistryModulesPage'; +import OpenDataPage from './OpenDataPage'; +import {PowerBIReportsPage} from './PowerBIReportsPage'; +import CostOptimizationWorkbookPage from './CostOptimizationWorkbookPage'; +import {SamplePage} from './SamplePage'; +import FluentUIProvider from '../components/FluentUIProvider'; // Use your FluentUIProvider Can it be that the FluentUIProvider in the components folder was not committed? Its not in this path — Reply to this email directly, view it on GitHub <#1077 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6QJFYCJ4GI4KTGWUHUYJZTZ5VK3LAVCNFSM6AAAAABQWD2W6SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJXGYZTSNRUGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[akiskips]

Tested deployment locally

[flanakin]

Looking at Ivan's feedback, I'm thinking we should probably break this PR down into smaller chunks to make progress. We can break theming, CSS breakout, localization, code cleanup, etc into separate tasks.