-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for [UX] Migrate existing markdown content to TSX pages #1056 Turn UX Design to Implementation #1077
Conversation
@flanakin, I forget to sync with latest from ux branch. There are conflicts that need to be resolved. |
Thanks, I forgot it. I'll commit it
β¦On Sun, 27 Oct 2024 at 23:25, Orthodoxos Kipouridis < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/web/pages/App.tsx
<#1077 (comment)>
:
> @@ -1,27 +1,41 @@
-import './App.css';
+import { BrowserRouter as Router, Route, Routes } from 'react-router-dom';
+import HomePage from './HomePage';
+import FinOpsHubsPage from './FinOpsHubsPage';
+import FinOpsWorkbooksPage from './FinOpsWorkbooksPage';
+import GovernanceWorkbookPage from './GovernanceWorkbookPage';
+import AzureOptimizationEnginePage from './AzureOptimizationEnginePage';
+import PowerShellModulePage from './PowerShellModulePage';
+import BicepRegistryModulesPage from './BicepRegistryModulesPage';
+import OpenDataPage from './OpenDataPage';
+import {PowerBIReportsPage} from './PowerBIReportsPage';
+import CostOptimizationWorkbookPage from './CostOptimizationWorkbookPage';
+import {SamplePage} from './SamplePage';
+import FluentUIProvider from '../components/FluentUIProvider'; // Use your FluentUIProvider
Can it be that the FluentUIProvider in the components folder was not
committed? Its not in this path
β
Reply to this email directly, view it on GitHub
<#1077 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6QJFYCJ4GI4KTGWUHUYJZTZ5VK3LAVCNFSM6AAAAABQWD2W6SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJXGYZTSNRUGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested deployment locally
Looking at Ivan's feedback, I'm thinking we should probably break this PR down into smaller chunks to make progress. We can break theming, CSS breakout, localization, code cleanup, etc into separate tasks. |
π οΈ Description
#1056
PR for turning figma design into implementation.
Top Menu Bar, Sidebar + Sample Page created.
Tests created
π· Screenshots
Jest test results
π Checklist
π¬ How did you test this change?
πββοΈ Do any of the following that apply?
π Did you update
docs/changelog.md
?π Did you update documentation?