Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move delay to nested pipeline to avoid blocking when ingesting into ADX. #1122

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

MSBrett
Copy link
Contributor

@MSBrett MSBrett commented Nov 11, 2024

πŸ› οΈ Description

Moves the wait activity to the nested pipeline to avoid blocking on the calling pipeline.
The calling pipeline should exit as quickly as possible to avoid hitting the hard limit of 100 concurrent triggered pipelines.

πŸ“· Screenshots

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@MSBrett MSBrett added Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Type: Cleanup Fixes to clean up any technical debt Status: πŸ”¬ Code review Issue is currently in code review with open PRs Skill: Data factory Data Factory integration Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution Resolution: Automerge This pull request can be merged automatically labels Nov 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers label Nov 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Skill: Deployment Resource deployment automation via bicep or terraform label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed Resolution: Automerge This pull request can be merged automatically Skill: Data factory Data Factory integration Skill: Deployment Resource deployment automation via bicep or terraform Status: πŸ”¬ Code review Issue is currently in code review with open PRs Tool: FinOps hubs Data pipeline solution Type: Cleanup Fixes to clean up any technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants