Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script updates for tooling #721

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Script updates for tooling #721

merged 6 commits into from
Sep 5, 2024

Conversation

willchavez
Copy link
Collaborator

  • diff.sh, now also downloads the previous versions of the updates file, and uses imagemagick to compare them.
  • Generate HTML Report, python script that creates a replica of the visual-diff tool we use for icon updates

icon_updates

@willchavez willchavez requested a review from spencer-nelson May 28, 2024 17:18
spencer-nelson
spencer-nelson requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@spencer-nelson spencer-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default values are a nicety, but I feel it's critical to include instructions about being on a valid branch. I've been caught by that too many times.

@willchavez
Copy link
Collaborator Author

@spencer-nelson just made some updates, excellent suggestions. 💯

@willchavez willchavez merged commit e2aec08 into main Sep 5, 2024
8 checks passed
@willchavez willchavez deleted the willchavez/diff_script branch September 5, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-nelson spencer-nelson spencer-nelson approved these changes

Assignees

@willchavez willchavez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willchavez @spencer-nelson