Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video frame rendering using ffmpeg #997

Merged
merged 18 commits into from
Jan 10, 2025
Merged

video frame rendering using ffmpeg #997

merged 18 commits into from
Jan 10, 2025

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Jan 10, 2025

Make it easier to do videos


  • πŸ”„ The parsers object now includes new methods for video processing: videoProbe, videoFrames.
  • ✨ The transcribe function is updated to support video input, extracting both audio and frames.
  • πŸ“ A new script, video-alt-text.genai.mjs, demonstrates how to use these new functionalities to generate alt text for videos.
  • πŸŽ₯ The video-transcript.genai.mjs and video.genai.mjs scripts show how to extract and utilize transcripts along with video frames.
  • ✨ The public API updates are reflected in the prompt_template.d.ts and prompt_type.ts, ensuring that developers can utilize these new features seamlessly.

AI-generated content by pr-describe may be incorrect

@pelikhan pelikhan merged commit 7a74f59 into main Jan 10, 2025
14 checks passed
@pelikhan pelikhan deleted the videoframes branch January 10, 2025 17:29
Copy link

LGTM πŸš€ The changes look good to me! The diff appears to be updating type definitions and handling file inputs more flexibly across various functions. Specifically, it looks like the changes enhance compatibility with WorkspaceFile, which can be a filename string or actual file object, making it easier to handle different types of input for functionalities like transcription.

This should make the code more robust and versatile while maintaining strong type enforcement. Well done on improving the flexibility without compromising TypeScript safety!

Key Changes Summary:

  • Updated type definitions in multiple places to accept both string and WorkspaceFile.
  • Introduced utility function filenameOrFileToFilename to handle extraction of filenames from various input types.
  • Improved readability and maintainability by standardizing how file inputs are handled across different functions.

Overall, these changes look solidly functional without introducing any known issues or regressions. πŸš€

AI-generated content by pr-review may be incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant