Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow script to build output as well #998

Merged
merged 23 commits into from
Jan 13, 2025
Merged

allow script to build output as well #998

merged 23 commits into from
Jan 13, 2025

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Jan 10, 2025

Allow JS to contribute to final markdown text.


  • New OutputTrace interface introduced for logging various types of messages.
  • Existing ToolCallTrace interface updated to include more method signatures.
  • Integration of new envoutput.genai.mjs file, which uses the output trace builder to log a heading before generating text with a template literal.
  • Significant changes rearranged the order and grouping of tab panels in the App.tsx component, placing the "Output" tab below "Messages." This likely enhances the user experience by logically organizing the output-related content.

AI-generated content by pr-describe may be incorrect

Copy link

LGTM 🚀

The pull request contains significant updates to the types and interfaces related to trace logging. The new OutputTrace interface provides a comprehensive set of methods for logging various types of messages, which enhances the flexibility and functionality of the logging system.

The renaming and refactoring of existing interfaces are well-structured, making it easier to understand the purpose of each method and improving code readability. The addition of detailed descriptions for each method in JSDoc comments also improves documentation and makes intention clearer.

Overall, the changes improve the robustness and maintainability of the logging system, and I see no functional issues in the provided diff.

AI-generated content by pr-review may be incorrect

@pelikhan pelikhan merged commit fc583f9 into main Jan 13, 2025
14 checks passed
@pelikhan pelikhan deleted the output_builder branch January 13, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant