Add "requireSecret" exclude tag for tests which require adding a secret to app registration #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2596 +/- ##
============================================
+ Coverage 51.35% 51.40% +0.05%
- Complexity 3972 3986 +14
============================================
Files 147 147
Lines 33664 33664
Branches 5626 5626
============================================
+ Hits 17288 17305 +17
- Misses 13939 13942 +3
+ Partials 2437 2417 -20 ☔ View full report in Codecov by Sentry. |
machavan
reviewed
Feb 6, 2025
| <exclude>**/com/microsoft/sqlserver/jdbc/ISQLServerConnection43.java</exclude> | ||
| <exclude>**/com/microsoft/sqlserver/jdbc/SQLServerConnection43.java</exclude> | ||
| <exclude>**/com/microsoft/sqlserver/jdbc/SQLServerJdbc43.java</exclude> | ||
| <exclude> |
There was a problem hiding this comment.
few newlines got introduced in pom.xml e.g. after tag
There was a problem hiding this comment.
nothing changed here I don't think? it's just spacing issue cos I ran the formatter
machavan
approved these changes
Feb 6, 2025
Jeffery-Wasty
approved these changes
Feb 6, 2025
tkyc
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.