Contribution by @DanCip00: PyRight integration #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed extra await that blocks code completion using Python Servers
Bugfix - code completion with python servers
bolinfest
reviewed
Jan 13, 2025
| self.server.on_notification("language/actionableNotification", do_nothing) | ||
|
|
||
| async with super().start_server(): | ||
| self.logger.log("Starting jedi-language-server server process", logging.INFO) |
LakshyAAAgrawal
commented
Jan 26, 2025
| config, | ||
| logger, | ||
| repository_root_path, | ||
| ProcessLaunchInfo(cmd="basedpyright-langserver --stdio", cwd=repository_root_path), |
There was a problem hiding this comment.
Could we please add at least a temporary setup_runtime_dependencies method, which for now just checks if "basedpyright-langserver" is installed, and if not, then links to a URL which guides how to install it, and fails gracefully with the error message
| @@ -497,7 +503,8 @@ async def request_completions( | |||
|
|
|||
| num_retries = 0 | |||
| while response is None or (response["isIncomplete"] and num_retries < 30): | |||
| await self.completions_available.wait() | |||
| if self.language_id != 'python': | |||
There was a problem hiding this comment.
Would it instead be better to go to the langserver file for these language servers, and just mark the self.completions_available as True in the langserver setup?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #10:
Removed extra await that blocks code completion for python Language Servers
Closes #9