Refactor emulator start and stop functions for clarity and efficiency #22861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…to Cjian/check_emulator_running
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| """Check if the emulator process is running based on a Popen instance.""" | ||
| return emulator_proc.poll() is None | ||
|
|
||
| import os |
Check warning
Code scanning / lintrunner
RUFF/E402 Warning
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+254
to
+256
|
|
||
| import os | ||
| def is_emulator_running_by_pid(emulator_pid: int) -> bool: |
There was a problem hiding this comment.
Suggested change
| import os | |
| def is_emulator_running_by_pid(emulator_pid: int) -> bool: | |
| import os | |
| def is_emulator_running_by_pid(emulator_pid: int) -> bool: |
snnn
added
the
platform:mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context