[TensorRT EP] mem leak fix #22863
Open
[TensorRT EP] mem leak fix #22863
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jywu-msft
previously approved these changes
Nov 16, 2024
jywu-msft
reviewed
Nov 16, 2024
| @@ -2413,7 +2413,7 @@ ORT_API(void, OrtApis::ReleaseTensorRTProviderOptions, _Frees_ptr_opt_ OrtTensor | |||
| delete[] ptr->trt_profile_opt_shapes; | |||
| delete[] ptr->trt_ep_context_file_path; | |||
| delete[] ptr->trt_onnx_model_folder_path; | |||
| if (ptr->trt_op_types_to_exclude) delete[] ptr->trt_op_types_to_exclude; | |||
| if (!ptr->trt_op_types_to_exclude && ptr->trt_op_types_to_exclude_str_is_dynamic_allocation) delete[] ptr->trt_op_types_to_exclude; | |||
jywu-msft
reviewed
Nov 16, 2024
| @@ -360,6 +360,9 @@ void TensorrtExecutionProviderInfo::UpdateProviderOptions(void* provider_options | |||
| trt_provider_options_v2.trt_engine_hw_compatible = internal_options.engine_hw_compatible; | |||
| trt_provider_options_v2.trt_onnx_bytestream = internal_options.onnx_bytestream; | |||
| trt_provider_options_v2.trt_onnx_bytestream_size = internal_options.onnx_bytestream_size; | |||
| trt_provider_options_v2.trt_op_types_to_exclude = copy_string_if_needed(internal_options.op_types_to_exclude); | |||
| if (options.find("trt_op_types_to_exclude") != options.end()) { | |||
| trt_provider_options_v2.trt_op_types_to_exclude = copy_string_if_needed(internal_options.op_types_to_exclude); | |||
There was a problem hiding this comment.
copy_string_if_needed() doesn't always dynamically allocate memory right? only if string_copy is true?
this is_dynamic_allocation check looks ugly.
jywu-msft
reviewed
Nov 16, 2024
| if (options.find("trt_op_types_to_exclude") != options.end()) { | ||
| trt_provider_options_v2.trt_op_types_to_exclude = copy_string_if_needed(internal_options.op_types_to_exclude); | ||
| trt_provider_options_v2.trt_op_types_to_exclude_str_is_dynamic_allocation = 1; | ||
| } |
There was a problem hiding this comment.
what if we dynamically allocate the ""NonMaxSuppression,NonZero,RoiAlign" string in the else case here if we don't find trt_op_types_to_exclude in options. then we would always need to deallocate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong logic and mem leak