Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude vmfirmwareigvm_dll #679

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

tjones60
Copy link
Contributor

@tjones60 tjones60 commented Jan 16, 2025

Unbreak 2411 aarch64 unit tests by excluding vmfirmwareigvm_dll, which doesn't have any tests anyway. Unclear what caused it to start failing.

@tjones60 tjones60 requested a review from a team as a code owner January 16, 2025 19:18
@github-actions github-actions bot added the release_2411 Targets the release/2411 branch. label Jan 16, 2025
Copy link
Contributor

@smalis-msft smalis-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd definitely want to know what's going on here, especially if there's a chance this break ends up in main, but as a quick fix yeah this is fine.

@chris-oo
Copy link
Member

chris-oo commented Jan 16, 2025

We can track the root cause in the corresponding issue #674 - I agree that we should figure out what's going on but at least we should unblock 2411 builds.

@chris-oo chris-oo merged commit fb4440d into microsoft:release/2411 Jan 16, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_2411 Targets the release/2411 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants