virt_mshv_vtl: Scope startvp handling to CVMs #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluck-msft
commented
Jan 25, 2025
| @@ -247,6 +247,13 @@ mod private { | |||
| dev: &impl CpuIo, | |||
| ) -> Result<bool, UhRunVpError>; | |||
|
|
|||
| fn handle_vp_start_enable_vtl_wake( | |||
There was a problem hiding this comment.
I ended up with this instead of a generic extended wake handler because WakeReason is currently at pub(crate) scope. If we prefer this to be a generic thing instead, happy to make some changes.
jstarks
reviewed
Jan 25, 2025
vm/hv1/hv1_emulator/src/cpuid.rs
Outdated
| @@ -42,10 +42,8 @@ pub fn hv_cpuid_leaves( | |||
| .with_access_apic_msrs(true) | |||
| .with_access_vp_runtime_msr(true) | |||
| .with_access_partition_reference_tsc(true) | |||
| .with_start_virtual_processor(true) | |||
| .with_start_virtual_processor(hardware_isolated) | |||
There was a problem hiding this comment.
This will disable StartVp support for WHP partitions using this emulator.
sluck-msft
force-pushed
the
start-vp-refactor
branch
from
8a29e28 to
7b2d374
Compare
jstarks
approved these changes
Jan 31, 2025
jstarks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring work so that the startvp hypercall is not handled by OpenHCL for non-CVMs. Will help to keep future CVM-only work isolated to the CVM backings.
Tested: