-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zerocopy: move repo to zerocopy 0.8 #735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkur
commented
Jan 28, 2025
mattkur
commented
Jan 28, 2025
mattkur
commented
Jan 28, 2025
smalis-msft
reviewed
Jan 28, 2025
smalis-msft
reviewed
Jan 28, 2025
smalis-msft
reviewed
Jan 28, 2025
smalis-msft
reviewed
Jan 28, 2025
smalis-msft
reviewed
Jan 28, 2025
This is a massive commit. Thankfully, much of the change is mechanical. This change leaves some classes of improvements & fix-ups: * map_err: These are cases where an error was already returned. Now that zerocopy 0.8 methods return a Result<...> rather than an Option<...>, those errors could be enriched with the details returned from the zerocopy methods. * err, option-to-err, unwrap, etc.: These are cases where an error is turned into a panic or None (Option). In these cases, the calling code could better leverage the zerocopy error handling. * review carefully: this is due to some cases where the changes are less mechanical, so should be treated as suspect. * *use-rest-of-range*: these are cases where the zerocopy support functions now return a tuple (T, &[u8]), where the slice is the rest of the buffer. In some cases, the code calling the zerocopy methods could use the resulting slice rather than walking the data type manually.
chris-oo
reviewed
Jan 29, 2025
smalis-msft
reviewed
Jan 30, 2025
gurasinghMS
reviewed
Jan 31, 2025
gurasinghMS
reviewed
Jan 31, 2025
gurasinghMS
reviewed
Jan 31, 2025
gurasinghMS
reviewed
Jan 31, 2025
gurasinghMS
reviewed
Jan 31, 2025
gurasinghMS
reviewed
Jan 31, 2025
gurasinghMS
reviewed
Jan 31, 2025
gurasinghMS
reviewed
Jan 31, 2025
gurasinghMS
reviewed
Jan 31, 2025
mattkur
commented
Jan 31, 2025
mattkur
commented
Jan 31, 2025
mattkur
commented
Jan 31, 2025
mattkur
commented
Jan 31, 2025
mattkur
commented
Jan 31, 2025
mattkur
commented
Jan 31, 2025
mattkur
commented
Jan 31, 2025
mattkur
commented
Jan 31, 2025
mattkur
commented
Jan 31, 2025
mattkur
commented
Jan 31, 2025
smalis-msft
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a massive commit. Thankfully, much of the change is mechanical.
This change leaves some classes of improvements & fix-ups:
zerocopy 0.8 methods return a Result<...> rather than an Option<...>,
those errors could be enriched with the details returned from the zerocopy
methods.
turned into a panic or None (Option). In these cases, the calling code
could better leverage the zerocopy error handling.
less mechanical, so should be treated as suspect.
functions now return a tuple (T, &[u8]), where the slice is the
rest of the buffer. In some cases, the code calling the zerocopy
methods could use the resulting slice rather than walking
the data type manually.
Fixes #313