virt_mshv_vtl: Returning appropriate values for various CPUIDs. #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
reviewed
Jan 30, 2025
| @@ -32,6 +35,8 @@ pub const TDX_REQUIRED_LEAVES: &[(CpuidFunction, Option<u32>)] = &[ | |||
| (CpuidFunction::CacheParameters, Some(3)), | |||
| ]; | |||
|
|
|||
| static mut MAX_XFD: u32 = 0; | |||
There was a problem hiding this comment.
statis muts are wildly unsafe, and the code as currently implemented provides no guarantee that there will be no concurrent accessors, even if there aren't today. Please remove this.
There was a problem hiding this comment.
This value doesn't even seem to be used anywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #556.