-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Actions Hub with environment retrieval and refresh functionality #1111
Open
amitjoshi438
wants to merge
40
commits into
main
Choose a base branch
from
users/amitjoshi/actionsHubRefreshEnv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+158
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…environment info retrieval in Actions Hub
…dTelemetryEvent and related functions
…pdate telemetry event calls
…activate function
…mmonMethods' of https://github.com/microsoft/powerplatform-vscode into users/amitjoshi/actionsHubRefreshEnv
…mmonMethods' of https://github.com/microsoft/powerplatform-vscode into users/amitjoshi/actionsHubRefreshEnv
…ctionsHubTreeDataProvider
priyanshu92
reviewed
Feb 5, 2025
src/client/power-pages/actions-hub/ActionsHubTreeDataProvider.ts
Outdated
Show resolved
Hide resolved
…g and simplifying the process
sanxsth
approved these changes
Feb 6, 2025
priyanshu92
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update tests for ActionsHub
and ActionsHubTreeDataProvider
…handling in ActionsHubTreeDataProvider
….com/microsoft/powerplatform-vscode into users/amitjoshi/actionsHubRefreshEnv
…handling in ActionsHubTreeDataProvider
….com/microsoft/powerplatform-vscode into users/amitjoshi/actionsHubRefreshEnv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
powerpages
extension, focusing on enhancing the Actions Hub functionality, improving error handling, and updating test cases accordingly. The most important changes include adding a refresh command, handling environment expiration errors, and updating the Actions Hub initialization and tests.Enhancements to Actions Hub functionality:
package.json
: Added a new commandpowerpages.actionsHub.refresh
with an associated icon and navigation group. [1] [2]src/client/power-pages/actions-hub/ActionsHubTreeDataProvider.ts
: Introduced a refresh method and registered a command to handle refresh actions. Updated the constructor to acceptpacTerminal
and added an event listener for environment changes. [1] [2]Error handling improvements:
src/client/OrgChangeNotifier.ts
: Added a comment to indicate that an event will be fired if the organization/environment is expired or deleted.src/client/extension.ts
: ImportedshowErrorDialog
andENVIRONMENT_EXPIRED
to handle environment expiration errors. Registered an error event to show a dialog when the environment is expired. [1] [2] [3]Updates to test cases:
src/client/test/Integration/power-pages/actions-hub/ActionsHubTreeDataProvider.test.ts
: Updated the test cases to includepacTerminal
in the initialization ofActionsHubTreeDataProvider
. [1] [2] [3] [4] [5] [6] [7] [8]Additional changes:
src/client/pac/PacAuthManager.ts
: Added an event emitter to handle environment changes and fire an event when authentication information is set. [1] [2]src/client/power-pages/actions-hub/Constants.ts
: Defined a new constantACTIONS_HUB_REFRESH_FAILED
and an interfaceAuthInfo
to manage authentication information.These changes collectively improve the functionality and reliability of the Actions Hub within the
powerpages
extension.