Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing TS dependency for RN < 0.71 #272

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fix missing TS dependency for RN < 0.71 #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d25c341
Fix missing TS dependency for RN <= 0.71
jonthysell Feb 2, 2024
48c8e87
pass through template
jonthysell Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,26 +30,42 @@ jobs:
strategy:
fail-fast: false
matrix:
rnwVersion: [ '0.71-stable', 'latest'] # test *all* versions that use VS 2022. aka any RNW version >= min in package.json and >= 0.71
rnwVersion: [ '0.72-stable', '0.71-stable'] # test *all* versions that use VS 2022. aka any RNW version >= min in package.json and >= 0.71
useRnwNuGet: [false, true] # test building with both RNW source and RNW NuGet
include:
- rnwVersion: '0.72-stable'
rnTemplate: '[email protected]'
- rnwVersion: '0.71-stable'
rnTemplate: '[email protected]'
uses: ./.github/workflows/template-testcli.yml
with:
vmImage: windows-2022
rnwVersion: ${{ matrix.rnwVersion }}
useRnwNuGet: ${{ matrix.useRnwNuGet }}
rnTemplate: ${{ matrix.rnTemplate }}

call-testcli-old:
name: Test CLI (VS 2019)
strategy:
fail-fast: false
matrix:
rnwVersion: ['0.67-stable', '0.68-stable', '0.69-stable', '0.70-stable'] # test *all* versions that use VS 2019. aka any RNW version >= min in package.json and < 0.71
rnwVersion: ['0.70-stable', '0.69-stable', '0.68-stable', '0.67-stable'] # test *all* versions that use VS 2019. aka any RNW version >= min in package.json and < 0.71
useRnwNuGet: [false, true] # test building with both RNW source and RNW NuGet
include:
- rnwVersion: '0.70-stable'
rnTemplate: '[email protected]'
- rnwVersion: '0.69-stable'
rnTemplate: '[email protected]'
- rnwVersion: '0.68-stable'
rnTemplate: '[email protected]'
- rnwVersion: '0.67-stable'
rnTemplate: '[email protected]'
uses: ./.github/workflows/template-testcli.yml
with:
vmImage: windows-2019
rnwVersion: ${{ matrix.rnwVersion }}
useRnwNuGet: ${{ matrix.useRnwNuGet }}
rnTemplate: ${{ matrix.rnTemplate }}

call-buildnpmpackage:
name: Build NPM Package
Expand Down
16 changes: 14 additions & 2 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,27 +42,39 @@ jobs:
strategy:
fail-fast: true
matrix:
rnwVersion: ['0.71-stable', 'latest'] # test *key* versions that use VS 2022. aka any RNW version >= 0.71 used by supported partners and/or Active/Maintenance from https://microsoft.github.io/react-native-windows/support
rnwVersion: ['0.72-stable', '0.71-stable'] # test *key* versions that use VS 2022. aka any RNW version >= 0.71 used by supported partners and/or Active/Maintenance from https://microsoft.github.io/react-native-windows/support
useRnwNuGet: [false, true] # test building with both RNW source and RNW NuGet
include:
- rnwVersion: '0.72-stable'
rnTemplate: '[email protected]'
- rnwVersion: '0.71-stable'
rnTemplate: '[email protected]'
uses: ./.github/workflows/template-testcli.yml
with:
vmImage: windows-2022
rnwVersion: ${{ matrix.rnwVersion }}
useRnwNuGet: ${{ matrix.useRnwNuGet }}
rnTemplate: ${{ matrix.rnTemplate }}

call-testcli-old:
name: Test CLI (VS 2019)
needs: setupcheck
strategy:
fail-fast: true
matrix:
rnwVersion: ['0.67-stable', '0.69-stable'] # test *key* versions that use VS 2019. aka any RNW version < 0.71 that are used by supported partners
rnwVersion: ['0.69-stable', '0.67-stable'] # test *key* versions that use VS 2019. aka any RNW version < 0.71 that are used by supported partners
useRnwNuGet: [false, true] # test building with both RNW source and RNW NuGet
include:
- rnwVersion: '0.69-stable'
rnTemplate: '[email protected]'
- rnwVersion: '0.67-stable'
rnTemplate: '[email protected]'
uses: ./.github/workflows/template-testcli.yml
with:
vmImage: windows-2019
rnwVersion: ${{ matrix.rnwVersion }}
useRnwNuGet: ${{ matrix.useRnwNuGet }}
rnTemplate: ${{ matrix.rnTemplate }}

call-buildnpmpackage:
name: Build NPM Package
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/template-testcli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ on:
required: false
default: false
type: boolean
rnTemplate:
required: false
default: 'react-native@latest'
type: string

jobs:
testcli:
Expand All @@ -34,7 +38,7 @@ jobs:
working-directory: package

- name: create react-native@${{ inputs.rnwVersion }} app
run: npx react-native init testrnx --template react-native@${{ inputs.rnwVersion }}
run: npx react-native init testrnx --template ${{ inputs.rnTemplate }}
working-directory: ../

- name: add Windows (RNW via ${{ inputs.useRnwNuGet && 'NuGet' || 'Source' }})
Expand Down
Loading