Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lunasvg] Update to 3.1.1 [plutosvg,plutovg] New ports #43567

Merged
merged 7 commits into from
Feb 11, 2025

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jan 31, 2025

New ports plutovg, plutosvg.
Official CMake config.
Shared library linkage.
Switch imgui opentype svg support to plutosvg. (Still doesn't build with lunasvg 3, and imgui misc/freetype/imgui_freetype.cpp states: "2024/10/17: added plutosvg support for SVG Fonts (seems faster/better than lunasvg).")

dg0yt added 5 commits January 31, 2025 18:20
Still doesn't build with lunasvg 3,
and imgui misc/freetype/imgui_freetype.cpp states:
2024/10/17: added plutosvg support for SVG Fonts (seems faster/better than lunasvg).
@dg0yt dg0yt changed the title [lunasvg] Update to 3.1.1 [lunasvg] Update to 3.1.1 [plutosvg,plutovg] New ports Feb 2, 2025
@WangWeiLin-MV WangWeiLin-MV added category:new-port The issue is requesting a new library to be added; consider making a PR! category:port-update The issue is with a library, which is requesting update new revision labels Feb 5, 2025
@dg0yt dg0yt marked this pull request as draft February 5, 2025 20:44
@dg0yt dg0yt marked this pull request as ready for review February 5, 2025 21:01
)

-FetchContent_MakeAvailable(plutovg)
+find_package(plutovg REQUIRED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port plutovg provides usage find_package(plutovg CONFIG REQUIRED)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what? No change needed.

Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ports imgui[freetype-svg], lunasvg, plutosvg, plutvg installation tests pass with the following triplets:

  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Feb 10, 2025
@BillyONeal BillyONeal merged commit 3dc84bb into microsoft:master Feb 11, 2025
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the update, and ports! @WangWeiLin-MV Thanks for testing!

@dg0yt dg0yt deleted the lunasvg branch February 11, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants