-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wildcards] add new port #43663
base: master
Are you sure you want to change the base?
[wildcards] add new port #43663
Conversation
Please get the failure logs for x64-osx here:
The steps to view CI errors are: #38994 (comment) |
@MonicaLiu0311 |
Typical problem: Writing files in the source directory while vcpkg is concurrently configuring debug and release builds. |
@dg0yt |
The usage test passed on |
@MonicaLiu0311 |
ports/wildcards/portfile.cmake
Outdated
|
||
vcpkg_cmake_configure( | ||
SOURCE_PATH "${SOURCE_PATH}" | ||
DISABLE_PARALLEL_CONFIGURE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why DISABLE_PARALLEL_CONFIGURE
is necessary?
Ah I see there was a conversation about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this library is actually header only when tests or examples are turned off which would make set(VCPKG_BUILD_TYPE release)
at the top of the file resolve this problem by there being only one configuration to build in the first place. Is my reading of the situation correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BillyONeal
I agree with you.
Let me try to add line.
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says.The generated "usage text" is accurate. See adding-usage for context../vcpkg x-add-version --all
and committing the result.