[openssl] emscripten toolchain controls thread support #43671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
changed the title
-pthread
LilyWangLL
added
the
category:port-bug
|
Has been successfully tested here: BOINC/boinc#6061 |
LilyWangLL
approved these changes
Feb 8, 2025
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. https://emscripten.org/docs/porting/pthreads.html:
For Pthreads support in emscripten, all C and C++ source files must be compiled AND linked with
pthread.Unconditionally enabling thread support in openssl made some downstream builds fail (#43463 (comment)), and even successful builds (as before #43463) would not comply with the documented requirement.
This PR couples openssl threads support for emscripten to the presence of
-pthreadin the C flags from the triplet/toolchain. Triplet/toolchain ensures that all C and C++ source files ae compiled AND linked withpthread(subject to per-port customization).This change has been tested with
vcpkg-ci-curl[core]:wasm32-emscriptenwith default settings (i.e. no-pthread) and withCFLAGS=-pthread.