-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libxlsxwriter] Don't use PkgConfig #43674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port fix tests pass with the following triplets:
- x64-windows
Thanks for the fix! |
Is this a fix that should be upstream in libxlsxwriter? I am the author/maintainer. |
This PR is a workaround to fix by disable PKGConfig. Could you mind look at a fix in another PR? #43655 |
You probably need to look at the problem (#43653), not at this PR. IMO jmcnamara/libxlsxwriter@d963343 introduced problems:
This breaks MSVC toolchains. pkg-config and CMake can play together even for MSVC (with some CMake quirks left), but you cannot use raw LDFLAGS because pc files usually carry them in non-MSVC syntax. That change has another "unusual" (if not wrong) pattern, using |
Thanks for that information. In that case I may revert the pkg-config change in libxlsxwriter. I'll look into it. |
Fixes #43653.
Alternative to #43655.