Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libxlsxwriter] Don't use PkgConfig #43674

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Feb 7, 2025

Fixes #43653.
Alternative to #43655.

@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Feb 7, 2025
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port fix tests pass with the following triplets:

  • x64-windows

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Feb 7, 2025
@BillyONeal BillyONeal merged commit a530693 into microsoft:master Feb 8, 2025
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the fix!

autoantwort pushed a commit to autoantwort/vcpkg that referenced this pull request Feb 8, 2025
@dg0yt dg0yt deleted the libxlsxwrite branch February 8, 2025 06:00
@BillyONeal BillyONeal mentioned this pull request Feb 11, 2025
7 tasks
@jmcnamara
Copy link
Contributor

Is this a fix that should be upstream in libxlsxwriter? I am the author/maintainer.

@WangWeiLin-MV
Copy link
Contributor

Is this a fix that should be upstream in libxlsxwriter?

This PR is a workaround to fix by disable PKGConfig.

Could you mind look at a fix in another PR? #43655

@dg0yt
Copy link
Contributor Author

dg0yt commented Feb 11, 2025

You probably need to look at the problem (#43653), not at this PR.

IMO jmcnamara/libxlsxwriter@d963343 introduced problems:

  • unexpectedly gave preference to pkg-config,
  • uses raw <Pkg>_LDFLAGS when available.

This breaks MSVC toolchains. pkg-config and CMake can play together even for MSVC (with some CMake quirks left), but you cannot use raw LDFLAGS because pc files usually carry them in non-MSVC syntax. <Pkg>_LIBRARIES might be okay, or <Pkg>_LINK_LIBRARIES.

That change has another "unusual" (if not wrong) pattern, using else(<Condition>). It is probably meant to mean to be elseif(<Condition>).

@jmcnamara
Copy link
Contributor

IMO jmcnamara/libxlsxwriter@d963343 introduced problems:

Thanks for that information. In that case I may revert the pkg-config change in libxlsxwriter. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libxlsxwriter] build failure if pkgconf is installed first
4 participants