Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Compiler Argument Traits #13278

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Conversation

kuchungmsft
Copy link
Contributor

  • Couldn't find examples of where this actually improved the prompt per ad-hoc analysis.

@kuchungmsft kuchungmsft requested a review from a team as a code owner February 13, 2025 18:47
sean-mcmanus

This comment was marked as resolved.

@kuchungmsft
Copy link
Contributor Author

Didn't we see that the standard version improved results? Is that already sent in a different code path?

Yes, language standard version trait was shipped a while ago in #12979 and it's not affected in this PR.

image

- Couldn't find examples of where this actually improved the prompt per ad-hoc analysis.
@kuchungmsft kuchungmsft force-pushed the kuchung/RemoveCompilerArgumentTraits branch from e36f945 to 90103dd Compare February 13, 2025 19:05
@sean-mcmanus sean-mcmanus added this to the 1.24.2 milestone Feb 13, 2025
@kuchungmsft kuchungmsft merged commit 9a9ac3a into main Feb 24, 2025
6 checks passed
@kuchungmsft kuchungmsft deleted the kuchung/RemoveCompilerArgumentTraits branch February 24, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants