Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unzip-stream instead of unzipper #172

Closed
wants to merge 1 commit into from

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Oct 26, 2022

unzipper seems unmaintained for quite some time now, last publish was 2 years ago https://www.npmjs.com/package/unzipper
https://github.com/ZJONSSON/node-unzipper
It has a dependency on an archived an unmaintained fstream ZJONSSON/node-unzipper#261 which leads to a CVE reported by npm audit

fixes #166

commands used to update dependency:
yarn remove unzipper @types/unzipper
yarn add unzip-stream
yarn add --dev @types/unzip-stream

unzipper seems unmaintained for quite some time now, last publish was 2
years ago https://www.npmjs.com/package/unzipper
https://github.com/ZJONSSON/node-unzipper
It has a dependency on an archived an unmaintained fstream
ZJONSSON/node-unzipper#261 which leads to a CVE reported by npm audit

fixes microsoft#166
@connor4312
Copy link
Member

unzip-stream's last publish was also 2 years ago. While there is the bad minimist version, it's not a code path used by this module. I don't see a lot of benefit in moving dependencies...

@connor4312
Copy link
Member

I'm swapping to jszip and moving away from unzipper entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from unzipper which is unmaintained
2 participants