quickopen: file url #190304
Open
quickopen: file url #190304
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
TylerLeonhardt
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Thanks for contributing! I don't think this is the right change. This is adding special logic to extractRangeFromFilter for file:// but it's not clear that a function called extractRangeFromFilter would do that.
I don't think this is the right place for this logic. I think the caller of extractRangeFromFilter or something in quick open code should normalize URIs to just their paths or something like that.
turuslan
force-pushed
the
quickpick/file-url
branch
from
3857f63 to
9c30b2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action: "Go to file..." (
workbench.action.quickOpen)Example query:
/etc/hostsResult: found "file results"
Example query:
file:///etc/hostsResult (expected): found "file results"
Result (actual): "No matching results"
VSCode supports opening
file://url with selection, e.g. when clicking such links in editor.P.S. I often copy
file://urls from chrome to open them in vscode