Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only invalidate terminal suggestions when whitespace is encountered #239400

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 1, 2025

Fixes #239017

After:

Recording 2025-02-01 at 06 15 51

It's possible after this that the suggestions may not be complete if an extension does not allow us to do the filtering, terminal-suggest should work fine though.

@Tyriar Tyriar added this to the February 2025 milestone Feb 1, 2025
@Tyriar Tyriar requested a review from meganrogge February 1, 2025 14:17
@Tyriar Tyriar self-assigned this Feb 1, 2025
@Tyriar Tyriar enabled auto-merge February 1, 2025 14:17
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but makes sense to me

@Tyriar Tyriar merged commit e923ba7 into main Feb 3, 2025
8 checks passed
@Tyriar Tyriar deleted the tyriar/239017 branch February 3, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions are not triggered on backspace
2 participants