Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal suggest absolute path support #239412

Merged
merged 7 commits into from
Feb 3, 2025
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 1, 2025

Fixes #237979

TODO:

Deferring C|, C:|, :| support as it's more complicated than I initially thought:

@Tyriar Tyriar added this to the February 2025 milestone Feb 1, 2025
@Tyriar Tyriar self-assigned this Feb 1, 2025
@Tyriar Tyriar requested a review from meganrogge February 1, 2025 19:35
@Tyriar
Copy link
Member Author

Tyriar commented Feb 1, 2025

@meganrogge hold off reviewing until #239406 is in.

@Tyriar Tyriar marked this pull request as ready for review February 1, 2025 19:36
@Muaytie23

This comment was marked as spam.

meganrogge
meganrogge previously approved these changes Feb 3, 2025
@Tyriar Tyriar dismissed meganrogge’s stale review February 3, 2025 18:47

The merge-base changed after approval.

@Tyriar Tyriar enabled auto-merge February 3, 2025 19:25
@Tyriar Tyriar merged commit 8f0aac0 into main Feb 3, 2025
8 checks passed
@Tyriar Tyriar deleted the tyriar/239401_cdpath__237979 branch February 3, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal suggest: support absolute paths well on Windows
3 participants