Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safer fix for 239274 #239511

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Safer fix for 239274 #239511

merged 2 commits into from
Feb 3, 2025

Conversation

roblourens
Copy link
Member

@roblourens roblourens commented Feb 3, 2025 •
edited
Loading

#239274

  • Revert previous fix which changed contextKeyService
  • Simpler fix by just ensuring that the new non-config context key value always changes when the setting is registered

@roblourens roblourens self-assigned this Feb 3, 2025
@roblourens roblourens changed the title Ensure agentModeDisallowed key always changes when setting is registered Safer fix for 239274 Feb 3, 2025
@roblourens roblourens added this to the January 2025 milestone Feb 3, 2025
@roblourens roblourens added the candidate Issue identified as probable candidate for fixing in the next release label Feb 3, 2025
@roblourens roblourens merged commit 14270fe into release/1.97 Feb 3, 2025
8 checks passed
@roblourens roblourens deleted the roblou/alternate-fix-239274 branch February 3, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@818Nawaf 818Nawaf 818Nawaf approved these changes

@connor4312 connor4312 connor4312 approved these changes

Assignees

@roblourens roblourens

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@roblourens @connor4312 @818Nawaf