use vscode API vs fs/promises for terminal suggest
#239531
Closed
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Feb 3, 2025
| @@ -86,7 +85,7 @@ export class PathExecutableCache implements vscode.Disposable { | |||
|
|
|||
| private async _getFilesInPath(path: string, pathSeparator: string, labels: Set<string>): Promise<Set<ICompletionResource> | undefined> { | |||
| try { | |||
There was a problem hiding this comment.
I find it weird that before this check for path &&, this was failing bc the vscode.workspace.fs.stat(vscode.Uri.file('')).then(stat) => stat.type === vscode.FileTypeDirectory, would return true
There was a problem hiding this comment.
with path of '', it finds tons of files
|
I don't think this is the right approach, thus closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #236831
Now
npm run watch-webruns smoothly.Noticed we don't use
import * as fs from 'fs/promises';in any other extensions, seems to cause problems.Edit: this will break things - we want to look globally - not related to the workspace.