Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pwsh-script-integration provider by default and remove parts of it #239830

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 6, 2025

Since we now have good general completions coming from terminal-suggest and will soon get deeper fig-powered ones, I've ripped out a bunch of stuff from the pwsh-script-integration provider. However I also enabled it by default and it now exclusively provides non-file/folder argument completions as options.

These are all terminal-suggest completions:

image
image

These contain both, with pwsh props at the top and files from terminal-suggest's fallback at the bottom:

image
image

This should give the best of both worlds, at least until we iterate more on the pwsh completions inside terminal-suggest.

Note that I also removed the code and git tab completion providers and the terminal.integrated.suggest.builtinCompletions setting since fig completions will replace it in a shell-agnostic way soon.

cc @TylerLeonhardt

@Tyriar Tyriar added this to the February 2025 milestone Feb 6, 2025
@Tyriar Tyriar requested a review from meganrogge February 6, 2025 17:35
@Tyriar Tyriar self-assigned this Feb 6, 2025
meganrogge
meganrogge previously approved these changes Feb 6, 2025
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@Tyriar Tyriar dismissed meganrogge’s stale review February 6, 2025 18:03

The merge-base changed after approval.

@Tyriar Tyriar marked this pull request as ready for review February 6, 2025 20:57
@Tyriar Tyriar requested a review from meganrogge February 6, 2025 20:57
@Tyriar Tyriar enabled auto-merge February 6, 2025 20:57
@Tyriar Tyriar merged commit 3108f00 into main Feb 6, 2025
8 checks passed
@Tyriar Tyriar deleted the tyriar/238986__item__dirfile__pwsh branch February 6, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants