Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add activeEditorState variable to window.title #239879

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Feb 7, 2025

fixes #237528

See also #239880

cc @rzhao271, this causes the separator to not be rendered - it looks like we cap the number of enum results that are displayed in the settings UI?
Screenshot 2025-02-06 at 9 11 06 PM

@meganrogge meganrogge requested a review from bpasero February 7, 2025 03:00
@meganrogge meganrogge self-assigned this Feb 7, 2025
@meganrogge meganrogge added this to the February 2025 milestone Feb 7, 2025
@meganrogge meganrogge enabled auto-merge (squash) February 7, 2025 03:01
@meganrogge meganrogge changed the title add editorStateInformation variable to window.title add editorStateInfo variable to window.title Feb 7, 2025
bpasero
bpasero previously requested changes Feb 7, 2025
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decorations are very chatty so this needs another thing like titleIncludesFocusedView imho

chrmarti
chrmarti previously approved these changes Feb 7, 2025
@meganrogge meganrogge changed the title add editorStateInfo variable to window.title add activeEditorState variable to window.title Feb 7, 2025
@meganrogge meganrogge merged commit c86f251 into main Feb 7, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/window-title-acc branch February 7, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editor tab decoration/hover info is not discoverable for screen reader users
4 participants