Optimistically show paste with imports if TS server takes to long when computing imports to add
#239899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen computing imports to add Fixes microsoft#235959 When pasting across files, sometimes users can see a spinner while we wait to see if TS has a `paste with imports` edit. This needs to be done even if we insert plain text by default so that we can then show the paste widget and user can select `paste with imports` This change makes it so that if TS takes over 200ms, we assume that a paste operation may be available and return an unresolved edit for it. Only when the edit then actually needs to be applied, we wait for TS to respond In most cases we won't need to wait because plain text will be pasted by default. Users will then only see the spinner after selecting `paste with imports`
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
jrieken
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235959
When pasting across files, sometimes users can see a spinner while we wait to see if TS has a
paste with importsedit. This needs to be done even if we insert plain text by default so that we can then show the paste widget and user can selectpaste with importsThis change makes it so that if TS takes over 200ms, we assume that a paste operation may be available and return an unresolved edit for it. Only when the edit then actually needs to be applied do we then wait for TS to respond
In most cases we won't need to wait because plain text will be pasted by default. Users will now only see the spinner after selecting
paste with importsof if they have configured it as the default pasteThe main downside is that we will now sometimes show
paste with importseven if selecting it does not actually add any imports (this will happened when we timed out getting the initial edit and then during resolve we learn there was not a valid paste edit)