Support incoming args for changeIcon & changeColor terminal commands #239973
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request permit the passing of args to the changeIcon/changeColor terminal commands.
This way, it’s possible to control icon and color of the terminal tab, from the terminal itself using remote-control extension.
Currently, trying to do so! would trigger the prompt to pop up even with a specified arg, as the args are not forwarded
I tested locally by adding the remote control extension to the extensions , and by running the provided command from a fresh terminal. (
websocat
was installed from brew on a macbook)I might need some guidance if automated test are to be added, or existing one adapted.
Preview