Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable emitting to single client in managers with to=... #1374

Conversation

rustworthy
Copy link
Contributor

@rustworthy rustworthy commented Aug 17, 2024

Addresses #1375

@miguelgrinberg
Copy link
Owner

Thanks!

The problem here is that the managers expect the addressee of the message to be given in the room argument, which is an alias of to in the main server and client classes. For consistency, the to argument needs to be added in all manager subclasses, not just the one you fixed.

@rustworthy
Copy link
Contributor Author

Thanks!

The problem here is that the managers expect the addressee of the message to be given in the room argument, which is an alias of to in the main server and client classes. For consistency, the to argument needs to be added in all manager subclasses, not just the one you fixed.

My pleasure!

Please see if I have identified all of them.

@rustworthy rustworthy changed the title Enable emitting to single client in AsyncPubSubManager Enable emitting to single client in managers with to=... Aug 18, 2024
@miguelgrinberg miguelgrinberg merged commit f147604 into miguelgrinberg:main Aug 20, 2024
18 of 19 checks passed
@miguelgrinberg
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants