Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix resolving named hosts. #203

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewwardrop
Copy link
Contributor

Version 0.6 broke our testing pipelines, because it "upgraded" hostnames to IP addresses, but didn't also upgrade the hostname passed in via arguments. This patch resolves this by also resolving hostnames passed in via arguments.

@codeclimate
Copy link

codeclimate bot commented Apr 1, 2023

Code Climate has analyzed commit 9f7c4b7 and detected 0 issues on this pull request.

View more on Code Climate.

@miketheman
Copy link
Owner

Thanks @matthewwardrop - I'm not entirely certain how this broke the testing pipeline - could you please add a test that expresses the conditions that you had that this change fixes?

@miketheman miketheman added the more-info-needed Further information is requested label May 17, 2023
@phil-nelson-bt
Copy link

Any chance this is going to get merged? This PR fixes a workaround for the now broken vs code python test runner which uses sockets. with pytest-socket using --disable-socket the test runner fails. The workaround, also not great because you may have false positive tests, but better than not being able to run individual tests in vs code, is to allow localhost. That is what this PR enables

@miketheman
Copy link
Owner

@phil-nelson-bt The change is waiting for a test, as per my last message.

@matthewwardrop
Copy link
Contributor Author

matthewwardrop commented Dec 15, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-info-needed Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants