Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build with kernel 5.6-rc1 #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix build with kernel 5.6-rc1 #27

wants to merge 1 commit into from

Conversation

MilhouseVH
Copy link
Contributor

Quick & dirty fix for 5.6-rc1. No problem if you'd rather fix this another way without the #ifdef.

Ref: torvalds/linux@d56c0d4

@GoTeamScotch
Copy link

Thanks for this. Does this kernel change affect how nuc_led is interacted with? Is it still through /proc/acpi/nuc_led? I'm not seeing anything in /proc/acpi besides 'wakeup'.

$ cat /proc/acpi/nuc_led
cat: /proc/acpi/nuc_led: No such file or directory
$ ls /proc/acpi
wakeup

On Ubuntu 18.04.3 (x64) on a NUC6CAY. This is after building and installing the .deb package (built using your patch to nuc_led.c).

@MilhouseVH
Copy link
Contributor Author

Unfortunately I don't know - I'm patching this blind as I don't have any LED hardware on my Skylake NUC6i5SYH. I only see /proc/acpi/wakeup with kernels 5.5.11 and 5.6-rc7. I'll see if I can find someone with the appropriate LED hardware...

@zauguin
Copy link

zauguin commented May 1, 2020

@MilhouseVH On my NUC with kernel 5.6.7 this patch works great!
Especially the file /proc/acpi/nuc_led still appears and both reading and writing work fine.

@MilhouseVH
Copy link
Contributor Author

Thanks. Never did find anyone to test this, so it's already been removed from LibreELEC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants