Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): stop calling groovy as grails / add gradle on kotlin usage #667

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

yahorbarkouski
Copy link
Contributor

hey, just a small remark regarding gradle usecase

  • groovy = jvm lang, that gradle accepts as a buildscript builder
  • grails = groovy web framework, nothing to do with gradle

@sre-ci-robot
Copy link

Welcome @yahorbarkouski! It looks like this is your first PR to milvus-io/milvus-sdk-java 🎉

@yhmo
Copy link
Contributor

yhmo commented Oct 18, 2023

@yahorbarkouski
Thank you for pointing out the problem. The pull request requires a Signed-off-by your github name and email address in the commit message. You can do this by using the -s flag (i.e., git commit -s).

@mergify mergify bot added the ci-passed label Oct 18, 2023
@yahorbarkouski
Copy link
Contributor Author

@yhmo done, thanks for the reminder!

@yhmo
Copy link
Contributor

yhmo commented Oct 19, 2023

/approve
/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yahorbarkouski, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2cb1e74 into milvus-io:master Oct 19, 2023
4 checks passed
yhmo pushed a commit to yhmo/milvus-sdk-java that referenced this pull request Oct 19, 2023
yhmo pushed a commit to yhmo/milvus-sdk-java that referenced this pull request Oct 19, 2023
yhmo pushed a commit to yhmo/milvus-sdk-java that referenced this pull request Oct 19, 2023
yhmo pushed a commit to yhmo/milvus-sdk-java that referenced this pull request Oct 19, 2023
sre-ci-robot pushed a commit that referenced this pull request Oct 19, 2023
Signed-off-by: yhmo <[email protected]>
Co-authored-by: Yahor Barkouski <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Oct 19, 2023
Signed-off-by: yhmo <[email protected]>
Co-authored-by: Yahor Barkouski <[email protected]>
yelusion2 pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants