Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update delete api, comment, types, test #262

Merged
merged 3 commits into from
Dec 15, 2023
Merged

update delete api, comment, types, test #262

merged 3 commits into from
Dec 15, 2023

Conversation

shanghaikid
Copy link
Contributor

No description provided.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: ryjiang <[email protected]>
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f83d438) 96.39% compared to head (d1d8dd2) 96.35%.

Files Patch % Lines
milvus/grpc/Data.ts 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   96.39%   96.35%   -0.05%     
==========================================
  Files          39       39              
  Lines        1859     1866       +7     
  Branches      440      444       +4     
==========================================
+ Hits         1792     1798       +6     
  Misses         64       64              
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ryjiang <[email protected]>
@shanghaikid shanghaikid merged commit dd8e4c3 into main Dec 15, 2023
2 of 5 checks passed
@shanghaikid shanghaikid deleted the delete_api branch December 15, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants