Apply suggestions from code review

review Co-authored-by: bthirion <[email protected]>
mind-inria · Jan 20, 2025 · f47917a · f47917a
1 parent a3773af
commit f47917a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/hidimstat/utils.py b/src/hidimstat/utils.py
@@ -125,7 +125,7 @@ def _bhy_threshold(pvals, reshaping_function=None, fdr=0.1):
         if selected_index <= n_features:
             return pvals_sorted[selected_index]
         else:
-            # no threshold, all the pvalue are positif
+            # no threshold, all the p-values are positive
             return -1.0
 
 

diff --git a/test/test_utils.py b/test/test_utils.py
@@ -34,7 +34,7 @@ def test_fdr_threshold():
 
 
 def test_fdr_threshold_extreme_values():
-    "test the extreme cases"
+    """test FDR computation for extreme numerical value of the p-values"""
     p_values = np.ones(100)
     e_values = 1 / p_values