Knockoffs(1/4): add comments and docstring of the functions #128
+1,055
−803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelkusch
requested review from
jpaillard
and removed request for
jpaillard
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 81.70% 82.88% +1.17%
==========================================
Files 43 39 -4
Lines 2312 2366 +54
==========================================
+ Hits 1889 1961 +72
+ Misses 423 405 -18 ☔ View full report in Codecov by Sentry. |
|
Some modifications of the code were done following the issue #125. |
lionelkusch
requested review from
jpaillard and
AngelReyero
and removed request for
bthirion
bthirion
reviewed
Jan 15, 2025
| model_x_knockoff_filter | ||
| model_x_knockoff_pvalue | ||
| model_x_knockoff_bootstrap_quantile | ||
| model_x_knockoff_bootstrap_e_value |
There was a problem hiding this comment.
Are all these functions meant to be public ?
There was a problem hiding this comment.
Yes, they should be public.
Small modification Co-authored-by: bthirion <[email protected]>
|
I merge the function model_x_knockoff and model_x_knockoff_aggregation together for having a unique function. |
|
LMK when you want another review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I aggregated most of the file for knockoff in one file.
I separate the main method from the computation of p_value and e_value and associate tests.