Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]: BBI documentation + Add LOCO as importance function #3

Merged
merged 24 commits into from
Jul 18, 2024
Merged

[FIX]: BBI documentation + Add LOCO as importance function #3

merged 24 commits into from
Jul 18, 2024

Conversation

achamma723
Copy link
Contributor

@achamma723 achamma723 commented Jul 9, 2024 •
edited
Loading

This PR closes #1:

  • Fix the documentation in:
    • BBI
    • Dnn_learner
    • Dnn_learner_single
    • compute_importance
    • utils
  • It introduces the implementation of LOCO by the mean of RF and DNN
  • It introduces the cross-os testing (Windows + MacOS + Linux)
  • It introduces the minimum versions of the packages by switching to pyproject.toml from setup.py (Removing also Manifest)

@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@achamma723 achamma723 changed the title [FIX]: Add LOCO as importance function [FIX]: BBI documentation + Add LOCO as importance function Jul 11, 2024
@bthirion
Copy link
Contributor

Please LMK whenever this is ready for review.

@achamma723
Copy link
Contributor Author

@bthirion, this PR is ready to review

bthirion
bthirion reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for opening this.
Please find a few comments below.

hidimstat/BBI.py Outdated Show resolved Hide resolved
hidimstat/BBI.py Outdated Show resolved Hide resolved
hidimstat/BBI.py Outdated Show resolved Hide resolved
hidimstat/BBI.py Outdated Show resolved Hide resolved
hidimstat/BBI.py Outdated Show resolved Hide resolved
hidimstat/compute_importance.py Outdated Show resolved Hide resolved
hidimstat/compute_importance.py Outdated Show resolved Hide resolved
hidimstat/importance_functions.py Outdated Show resolved Hide resolved
hidimstat/test/test_importance_funtions.py Outdated Show resolved Hide resolved
hidimstat/test/test_importance_funtions.py Outdated Show resolved Hide resolved
@achamma723
Copy link
Contributor Author

achamma723 commented Jul 16, 2024 •
edited
Loading

@bthirion, this PR is ready for another review.
I have also worked on the Multi-os testing and the pyproject.toml for the minimum version of the dependencies and the release
For now, it is a bug related to the windows os (working with linux and mac)

@bthirion bthirion mentioned this pull request Jul 18, 2024
Open
bthirion
bthirion reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Just a bunch of details left.

hidimstat/BBI.py Show resolved Hide resolved
hidimstat/BBI.py Outdated Show resolved Hide resolved
hidimstat/BBI.py Outdated Show resolved Hide resolved
hidimstat/BBI.py Outdated Show resolved Hide resolved
hidimstat/BBI.py Outdated Show resolved Hide resolved
hidimstat/Dnn_learner_single.py Outdated Show resolved Hide resolved
hidimstat/Dnn_learner_single.py Outdated Show resolved Hide resolved
hidimstat/Dnn_learner_single.py Outdated Show resolved Hide resolved
hidimstat/Dnn_learner_single.py Outdated Show resolved Hide resolved
hidimstat/Dnn_learner_single.py Outdated Show resolved Hide resolved
This was referenced Jul 18, 2024
Closed
Merged
@achamma723
Copy link
Contributor Author

@bthirion all comments are tackled, do you think it is ready to be merged?

@bthirion
Copy link
Contributor

One of the build fails ? @achamma723

@achamma723
Copy link
Contributor Author

achamma723 commented Jul 18, 2024 •
edited
Loading

One of the build fails ? @achamma723

As I understood, it is related to a recent bug for calling pytorch in windows OS.

@bthirion
Copy link
Contributor

OK, merging.

@bthirion bthirion merged commit b939781 into mind-inria:main Jul 18, 2024
7 of 8 checks passed
@bthirion
Copy link
Contributor

Can you clen the other PRs, so that we really see what's novel there ? Thx,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthirion bthirion bthirion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LOCO with RF implementation
2 participants
@achamma723 @bthirion