Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the warning and error from sphinx #82

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

lionelkusch
Copy link
Collaborator

This PR is just to remove the warning and the error from the actual documentation.
This PR is done for starting to modified and debug the future documentation.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.09%. Comparing base (e95b4f6) to head (358bd68).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   77.09%   77.09%           
=======================================
  Files          46       46           
  Lines        2471     2471           
=======================================
  Hits         1905     1905           
  Misses        566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

Copy link
Collaborator

@jpaillard jpaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.
There's this issue of inconsistent way of citing, for instance in the doc of LOCO and ada_svr. But I guess that's for another PR.

@lionelkusch
Copy link
Collaborator Author

lionelkusch commented Dec 20, 2024

Yes, I will homogenise the citation when I modify the docstring of each model.

see #38

@lionelkusch lionelkusch merged commit 19bf255 into main Dec 20, 2024
9 checks passed
@lionelkusch lionelkusch deleted the PR_documentation branch December 20, 2024 14:34
@lionelkusch lionelkusch mentioned this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants